Bug 215825

Summary: [Mac,EME] Netflix.com shows HDCP error for all streams
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing none

Description Jer Noble 2020-08-25 14:17:41 PDT 
[Mac,EME] Netflix.com shows HDCP error for all streams
Comment 1 Jer Noble 2020-08-25 14:22:40 PDT 
<rdar://problem/66948621>
Comment 2 Jer Noble 2020-08-25 14:26:54 PDT 
Created attachment 407231 [details]
Patch
Comment 3 Eric Carlson 2020-08-25 14:35:51 PDT 
Comment on attachment 407231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review

> Source/WebCore/ChangeLog:11
> +        displayID. This causes AVFoundation to do a "lowest common level  of support" rather than a specific display check.

s/level  of support/level of support/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1388
> +bool CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID(AVContentKeyRequest  *request, PlatformDisplayID displayID) const

s/AVContentKeyRequest  *request/AVContentKeyRequest *request/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1390
> +    // willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays will always return "YES" prior

s/return "YES" prior/return "YES" prior to/

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1400
> +    // and to query the HDCP level required by each AVContentKeyRequest, and do the comparison between th two in the

s/between th two/between the two/
Comment 4 Peng Liu 2020-08-25 14:43:35 PDT 
Comment on attachment 407231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review

> Source/WebCore/ChangeLog:13
> +        AVContentKeyRequest will report that it's output is restricted if any non-HDCP compliant display is attached.

s/it's/its
Comment 5 Jer Noble 2020-08-25 14:57:07 PDT 
Created attachment 407237 [details]
Patch for landing
Comment 6 EWS 2020-08-26 10:57:11 PDT 
Committed r266176: <https://trac.webkit.org/changeset/266176>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407237 [details].