Bug 215788

Summary: Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 215802    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-08-24 17:54:55 PDT
Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
Attachments
Patch (9.80 KB, patch)
2020-08-24 17:59 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (13.42 KB, patch)
2020-08-24 19:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.95 KB, patch)
2020-08-25 10:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-08-24 17:59:52 PDT
Created attachment 407152 [details] Patch
Alex Christensen
Comment 2 2020-08-24 19:37:59 PDT
Created attachment 407161 [details] Patch
Alex Christensen
Comment 3 2020-08-24 19:46:00 PDT
Comment on attachment 407161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407161&action=review > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:-193 > - if (m_sessionID.isEphemeral() || hstsStorageDirectory().isNull()) I guess this wasn't dead code, but it needs to come through the NetworkSessionCreationParameters instead of the NetworkProcessCreationParameters now. Could someone implement that for GTK/WPE?
Alex Christensen
Comment 4 2020-08-25 10:17:16 PDT
Soup part of this was done well in r266112
Alex Christensen
Comment 5 2020-08-25 10:20:50 PDT
Created attachment 407204 [details] Patch
EWS
Comment 6 2020-08-25 11:06:48 PDT
Committed r266133: <https://trac.webkit.org/changeset/266133> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407204 [details].
Radar WebKit Bug Importer
Comment 7 2020-08-25 11:07:18 PDT
<rdar://problem/67747536>
Note You need to log in before you can comment on or make changes to this bug.