Bug 215781

Summary: [macOS] Update audio arbitration manager when audio transport changes
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Eric Carlson
Reported 2020-08-24 13:26:29 PDT
Update audio arbitration manager when audio transport changes
Attachments
Patch (22.74 KB, patch)
2020-08-24 13:43 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (22.75 KB, patch)
2020-08-24 14:25 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.72 KB, patch)
2020-08-24 15:36 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2020-08-24 13:26:59 PDT
<rdar://problem/65920613>
Eric Carlson
Comment 2 2020-08-24 13:43:29 PDT
Created attachment 407131 [details] Patch
Eric Carlson
Comment 3 2020-08-24 14:25:12 PDT
Created attachment 407135 [details] Patch
Jer Noble
Comment 4 2020-08-24 15:11:30 PDT
Comment on attachment 407135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407135&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58 > + <CommandLineArguments> > + <CommandLineArgument > + argument = "--gtest_filter=AudioRoutingArbitration.Updating" > + isEnabled = "YES"> > + </CommandLineArgument> > + </CommandLineArguments> Nit: probably don't need to land this change.
Eric Carlson
Comment 5 2020-08-24 15:36:16 PDT
Created attachment 407144 [details] Patch for landing
EWS
Comment 6 2020-08-25 09:15:39 PDT
Committed r266121: <https://trac.webkit.org/changeset/266121> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407144 [details].
Note You need to log in before you can comment on or make changes to this bug.