Bug 215781 - [macOS] Update audio arbitration manager when audio transport changes
Summary: [macOS] Update audio arbitration manager when audio transport changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-24 13:26 PDT by Eric Carlson
Modified: 2020-08-25 09:15 PDT (History)
6 users (show)

See Also:


Attachments
Patch (22.74 KB, patch)
2020-08-24 13:43 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch (22.75 KB, patch)
2020-08-24 14:25 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing (21.72 KB, patch)
2020-08-24 15:36 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-08-24 13:26:29 PDT
Update audio arbitration manager when audio transport changes
Comment 1 Eric Carlson 2020-08-24 13:26:59 PDT
<rdar://problem/65920613>
Comment 2 Eric Carlson 2020-08-24 13:43:29 PDT
Created attachment 407131 [details]
Patch
Comment 3 Eric Carlson 2020-08-24 14:25:12 PDT
Created attachment 407135 [details]
Patch
Comment 4 Jer Noble 2020-08-24 15:11:30 PDT
Comment on attachment 407135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407135&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58
> +      <CommandLineArguments>
> +         <CommandLineArgument
> +            argument = "--gtest_filter=AudioRoutingArbitration.Updating"
> +            isEnabled = "YES">
> +         </CommandLineArgument>
> +      </CommandLineArguments>

Nit: probably don't need to land this change.
Comment 5 Eric Carlson 2020-08-24 15:36:16 PDT
Created attachment 407144 [details]
Patch for landing
Comment 6 EWS 2020-08-25 09:15:39 PDT
Committed r266121: <https://trac.webkit.org/changeset/266121>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407144 [details].