Bug 21576

Summary:

Fix a race in fast/history/history_reload.html

Product:

WebKit

Reporter:

Pam Greene (IRC:pamg) <pam>

Component:

Tools / Tests

Assignee:

Pam Greene (IRC:pamg) <pam>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fixed test	timothy: review+

Description Pam Greene (IRC:pamg) 2008-10-13 12:34:49 PDT

The fast/history/history_reload.html test has a potential race condition caused by higher-resolution timers.  I don't know exactly what threshold it takes to expose the problem, but it's worth removing anyway.

Each time the subframe loads, the onclose handler calls layoutTestController.notifyDone via setTimeout(0). If that gets fired before the history.go() completes, the test appears to have failed.

One solution is to always use two passes in the test, and not complete until the second one.

Comment 1 Pam Greene (IRC:pamg) 2008-10-13 12:47:23 PDT

Created attachment 24322 [details]
Fixed test

No change to expected results.

Comment 2 Pam Greene (IRC:pamg) 2008-10-17 11:08:06 PDT

Landed in r37657.