Bug 215753

Summary: Do not use undefined default param in CSSStyleDeclaration.idl
Product: WebKit Reporter: Rob Buis <rbuis>
Component: DOMAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Rob Buis 2020-08-22 10:12:48 PDT 
Do not use undefined default parameter value in CSSStyleDeclaration.idl, instead use no explicit default
parameter at all. This means a zero length String will be used, which will be more efficient when using
the cssPropertyID helper method, as well as less error-prone.
Comment 1 Rob Buis 2020-08-22 10:13:58 PDT 
Created attachment 407054 [details]
Patch
Comment 2 Darin Adler 2020-08-22 14:11:43 PDT 
Comment on attachment 407054 [details]
Patch

Could we have added a tests? Or is there no way to detect that we are failing to look up "undefined" vs. failing to look up a null string?
Comment 3 Rob Buis 2020-08-23 06:38:50 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 407054 [details]
> Patch
> 
> Could we have added a tests? Or is there no way to detect that we are
> failing to look up "undefined" vs. failing to look up a null string?

I think the only way is through timing both lookups, and asserting that the null string lookup (early exit) will take less time than looking up "undefined". I personally thing this is a bit overkill but let me know if you want me to add such a test.
Comment 4 EWS 2020-08-23 06:40:29 PDT 
Committed r266046: <https://trac.webkit.org/changeset/266046>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407054 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-23 06:41:14 PDT 
<rdar://problem/67640590>