Summary: | [GTK][WPE] Compilation warnings with clang/gcc 10 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||
Component: | WebKitGTK | Assignee: | Philippe Normand <pnormand> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alecflett, annulen, beidson, bugs-noreply, cdumez, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, jsbell, kangil.han, ryuan.choi, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Philippe Normand
2020-08-20 09:16:57 PDT
Created attachment 406936 [details]
Patch
Created attachment 406942 [details]
Patch
Created attachment 406943 [details]
Patch
Comment on attachment 406943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406943&action=review > Source/WebCore/ChangeLog:15 > + matchingRuns assignment. I have no idea how this was supposed to work? It worked like bool matchingRuns = (matchingRuns = checkForMatchingNonTextRuns(...)); Assignment operator returns assigned value so matchingRuns was assigned twice Committed r266025: <https://trac.webkit.org/changeset/266025> |