Bug 215696

Summary: Cocoa WebSocketTask should expose WebSocket server extensions
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, darin, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-08-20 05:55:11 PDT
Cocoa WebSocketTask should expose WebSocket server extensions
Attachments
Patch (7.33 KB, patch)
2020-08-20 06:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-08-20 08:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.41 KB, patch)
2020-08-24 07:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-08-20 06:00:19 PDT
Created attachment 406926 [details] Patch
youenn fablet
Comment 2 2020-08-20 08:37:55 PDT
Created attachment 406932 [details] Patch
Darin Adler
Comment 3 2020-08-21 09:44:32 PDT
Comment on attachment 406926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406926&action=review > Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm:99 > + auto *response = [m_task response]; I suggest just auto here. I don’t think the * adds anything.
youenn fablet
Comment 4 2020-08-24 07:21:32 PDT
Created attachment 407101 [details] Patch for landing
EWS
Comment 5 2020-08-24 07:58:03 PDT
Committed r266057: <https://trac.webkit.org/changeset/266057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407101 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-24 07:59:15 PDT
<rdar://problem/67679855>
Note You need to log in before you can comment on or make changes to this bug.