Bug 215685

Summary: CTFontGetPhysicalSymbolicTraits() is faster than CTFontCopyPhysicalFont()/CTFontGetSymbolicTraits()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 215684    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
darin: review+
Patch for committing none

Myles C. Maxfield
Reported 2020-08-19 20:45:27 PDT
We can take a shortcut.
Attachments
Patch (7.67 KB, patch)
2020-08-19 20:55 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (8.81 KB, patch)
2020-09-06 15:31 PDT, Myles C. Maxfield 		darin: review+
DetailsFormatted DiffDiff
Patch for committing (8.80 KB, patch)
2020-09-06 17:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2020-08-19 20:55:30 PDT
Created attachment 406910 [details] Patch
Myles C. Maxfield
Comment 2 2020-08-19 21:43:18 PDT
This patch needs to modify CoreTextSPI.h.
Myles C. Maxfield
Comment 3 2020-08-19 21:52:14 PDT
<rdar://problem/51631817>
Myles C. Maxfield
Comment 4 2020-09-06 15:31:26 PDT
Created attachment 408142 [details] Patch
Darin Adler
Comment 5 2020-09-06 16:50:02 PDT
Comment on attachment 408142 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408142&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:858 > + RetainPtr<CTFontRef> fontForSynthesisComputation = font; auto fontForSynthesisComputation = retainPtr(font); > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:57 > +enum class ShouldComputePhysicalTraits : uint8_t { > + Yes, > + No > +}; I suggest bool instead of uint8_t, No before Yes, and putting this on a single line instead of vertically on 4 lines.
Myles C. Maxfield
Comment 6 2020-09-06 17:15:32 PDT
Created attachment 408153 [details] Patch for committing
EWS
Comment 7 2020-09-06 18:33:35 PDT
Committed r266690: <https://trac.webkit.org/changeset/266690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408153 [details].
Note You need to log in before you can comment on or make changes to this bug.