Bug 21567

Summary: prepare-ChangeLog should know how to find functions in JavaScript files
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Tools / TestsAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, darin, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch ddkilzer: review+

Timothy Hatcher
Reported 2008-10-13 10:23:55 PDT
Since most of the Web Inspector is JavaScript, we should make prepare-ChangeLog work with JavaScripts.
Attachments
Proposed patch (8.26 KB, patch)
2008-10-13 10:46 PDT, Timothy Hatcher
ddkilzer: review+
Timothy Hatcher
Comment 1 2008-10-13 10:46:45 PDT
Created attachment 24315 [details] Proposed patch
David Kilzer (:ddkilzer)
Comment 2 2008-10-14 11:39:57 PDT
Comment on attachment 24315 [details] Proposed patch # Only look for function names in .c files. Please fix this comment (I know it's been there forever). Perhaps to "...in certain source files."? Also, please declare "sub get_function_line_ranges_for_javascript($$)" at the top of the source file. Otherwise looks great! r=me with the above changes.
Timothy Hatcher
Comment 3 2008-10-14 12:17:31 PDT
Landed in r37588.
Note You need to log in before you can comment on or make changes to this bug.