Bug 215669

Summary: AudioBufferSourceNode should use "final" values for playbackRate and detune
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-08-19 16:52:45 PDT
AudioBufferSourceNode should use "final" values for playbackRate and detune to take into account changes to the AudioParamTimeline (for example, when AudioBufferSourceNode.playbackRate.setValueAtTime() is called).
Attachments
Patch (9.79 KB, patch)
2020-08-19 16:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.41 KB, patch)
2020-08-20 10:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-19 16:54:51 PDT
Created attachment 406887 [details] Patch
Eric Carlson
Comment 2 2020-08-20 09:27:20 PDT
Looks like this is causing lots of asserts in tests.
Chris Dumez
Comment 3 2020-08-20 10:32:39 PDT
Created attachment 406944 [details] Patch
Chris Dumez
Comment 4 2020-08-20 15:52:55 PDT
(In reply to Eric Carlson from comment #2) > Looks like this is causing lots of asserts in tests. Yes, turns out you can only call finalValue() from the AudioThread. This is fixed now.
EWS
Comment 5 2020-08-20 16:15:23 PDT
Committed r265981: <https://trac.webkit.org/changeset/265981> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406944 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-20 16:16:18 PDT
<rdar://problem/67513315>
Note You need to log in before you can comment on or make changes to this bug.