Summary: | AudioBufferSourceNode should use "final" values for playbackRate and detune | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clark_wang, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 212611 | ||||||||
Attachments: |
|
Description
Chris Dumez
2020-08-19 16:52:45 PDT
Created attachment 406887 [details]
Patch
Looks like this is causing lots of asserts in tests. Created attachment 406944 [details]
Patch
(In reply to Eric Carlson from comment #2) > Looks like this is causing lots of asserts in tests. Yes, turns out you can only call finalValue() from the AudioThread. This is fixed now. Committed r265981: <https://trac.webkit.org/changeset/265981> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406944 [details]. |