Summary: | [ macOS ] accessibility/mac/select-element-selection-with-optgroups.html is a flaky failure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hector Lopez <hector_i_lopez> | ||||||
Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=175341 | ||||||||
Attachments: |
|
Description
Hector Lopez
2020-08-19 08:58:00 PDT
Test expectation while investigated: https://trac.webkit.org/changeset/265862/webkit Created attachment 411016 [details]
Patch
Comment on attachment 411016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411016&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:959 > + Vector<RefPtr<AXCoreObject>> axObjects; can we use the map function in Vector to make this use less code? > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:154 > + result.reserveCapacity(objects.size()); can we use a map function to reduce code? Created attachment 411249 [details]
Patch
(In reply to chris fleizach from comment #4) > Comment on attachment 411016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411016&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:959 > > + Vector<RefPtr<AXCoreObject>> axObjects; > > can we use the map function in Vector to make this use less code? Done. > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:154 > > + result.reserveCapacity(objects.size()); > > can we use a map function to reduce code? Done. Committed r268454: <https://trac.webkit.org/changeset/268454> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411249 [details]. |