Bug 215644 – WebSocketChannel::didClose should correctly compute whether a closing handshake was received

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

WebSocketChannel::didClose should correctly compute whether a closing handshake was received

[youenn fablet]

Created attachment 406840 [details]
Patch

[Darin Adler]

Comment on attachment 406840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review

> Source/WebKit/ChangeLog:8
> +        Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.

Where is that code path enabled? Why aren’t we seeing the failure in any bot?

[youenn fablet]

Comment on attachment 406840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review

>> Source/WebKit/ChangeLog:8
>> +        Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.
> 
> Where is that code path enabled? Why aren’t we seeing the failure in any bot?

This code path is off by default on all bots. It can be enabled in Safari as an experimental feature.
We are working on reducing the test results between the two code paths before enabling this code path.

[EWS]

Committed r265856: <https://trac.webkit.org/changeset/265856>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406840 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67405340>