Bug 215633

Summary:

[run-webkit-tests] Rosetta specific test expectations

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, darin, dewei_zhu, ews-watchlist, glenn, rackler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=213761

Attachments:

Description	Flags
Patch	none
Patch	none

Jonathan Bedard

Reported 2020-08-18 17:10:07 PDT

Without https://bugs.webkit.org/show_bug.cgi?id=213761, we need Rosetta specific test expectation parsing. I'm adding a temporary Rosetta special case on Mac so that we can retain coverage for Intel Macs on Big Sur.

Attachments
Patch (3.50 KB, patch) 2020-08-18 17:15 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (9.10 KB, patch) 2020-08-18 17:39 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2020-08-18 17:10:25 PDT

<rdar://problem/67353771>

Jonathan Bedard

Comment 2 2020-08-18 17:15:32 PDT

Created attachment 406824 [details] Patch

Darin Adler

Comment 3 2020-08-18 17:18:15 PDT

Comment on attachment 406824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406824&action=review Could we include or convert at least *one* expectation using this mechanism in the same patch that adds it? > Tools/Scripts/webkitpy/port/mac_unittest.py:274 > + def test_rosetta_expecrtations(self): Typo "expecrtations"

Jonathan Bedard

Comment 4 2020-08-18 17:19:43 PDT

(In reply to Darin Adler from comment #3) > Comment on attachment 406824 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406824&action=review > > Could we include or convert at least *one* expectation using this mechanism > in the same patch that adds it? > > > Tools/Scripts/webkitpy/port/mac_unittest.py:274 > > + def test_rosetta_expecrtations(self): > > Typo "expecrtations" Yes, intended to include an expectation file, but forgot to svn add it

Darin Adler

Comment 5 2020-08-18 17:22:23 PDT

(In reply to Jonathan Bedard from comment #4) > Yes, intended to include an expectation file, but forgot to svn add it Is this a whole separate file? I’m getting less and less enamored of separate TestExpectations files -- there are just too many and hard to understand their relationship -- and more with syntax within the one big Mac TestExpectation file.

Jonathan Bedard

Comment 6 2020-08-18 17:39:04 PDT

(In reply to Darin Adler from comment #5) > (In reply to Jonathan Bedard from comment #4) > > Yes, intended to include an expectation file, but forgot to svn add it > > Is this a whole separate file? > > I’m getting less and less enamored of separate TestExpectations files -- > there are just too many and hard to understand their relationship -- and > more with syntax within the one big Mac TestExpectation file. Totally agree! <https://bugs.webkit.org/show_bug.cgi?id=213761> covers exactly that, this is intended as a stop-gap so we can defend Rosetta in the mean time. Hoping to get to that bug in September, since it also block Catalyst layout tests.

Jonathan Bedard

Comment 7 2020-08-18 17:39:11 PDT

Created attachment 406826 [details] Patch

EWS

Comment 8 2020-08-18 19:34:57 PDT

Committed r265846: <https://trac.webkit.org/changeset/265846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406826 [details].

Note You need to log in before you can comment on or make changes to this bug.