Bug 215619

Summary: [macOS] Move stepper painting code off of Carbon API
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Aditya Keerthi
Reported 2020-08-18 12:38:19 PDT
This will ensure the stepper has an appropriate appearance in dark mode.
Attachments
Patch (9.05 KB, patch)
2020-08-18 13:11 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.47 KB, patch)
2020-08-18 15:06 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (3.71 KB, patch)
2020-08-20 11:11 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-08-18 12:39:27 PDT
<rdar://problem/41936617>
Aditya Keerthi
Comment 2 2020-08-18 13:11:43 PDT
Created attachment 406802 [details] Patch
Darin Adler
Comment 3 2020-08-18 13:55:37 PDT
Comment on attachment 406802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406802&action=review We should figure out how to make test coverage for this. > Source/WebCore/platform/mac/ThemeMac.mm:637 > + ControlStates::States states = controlStates.states(); Consider auto here instead of writing out the type ControlStates::States > Source/WebCore/platform/mac/ThemeMac.mm:672 > + (__bridge NSString *)kCUIWidgetKey: (__bridge NSString *)kCUIWidgetButtonLittleArrows, > + (__bridge NSString *)kCUISizeKey: coreUISize, > + (__bridge NSString *)kCUIStateKey: coreUIState, > + (__bridge NSString *)kCUIValueKey: (states & ControlStates::SpinUpState) ? @1 : @0, > + (__bridge NSString *)kCUIIsFlippedKey : @NO, > + (__bridge NSString *)kCUIScaleKey : @1, > + (__bridge NSString *)kCUIMaskOnlyKey : @NO Mixed formatting here about whether the ":" has a space before it or not.
Aditya Keerthi
Comment 4 2020-08-18 15:06:32 PDT
Created attachment 406817 [details] Patch for landing
Aditya Keerthi
Comment 5 2020-08-18 15:07:48 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 406802 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406802&action=review > > We should figure out how to make test coverage for this. I added a reference mismatch test to verify that the stepper has a different appearance under dark mode.
EWS
Comment 6 2020-08-19 09:03:39 PDT
Committed r265860: <https://trac.webkit.org/changeset/265860> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406817 [details].
Aditya Keerthi
Comment 7 2020-08-20 11:11:44 PDT
Reopening to attach new patch.
Aditya Keerthi
Comment 8 2020-08-20 11:11:45 PDT
Created attachment 406947 [details] Patch
Aditya Keerthi
Comment 9 2020-08-20 11:13:49 PDT
Uploaded a patch to the wrong bug.
Note You need to log in before you can comment on or make changes to this bug.