Bug 215617

Summary: Make some small improvements involving sorting
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214883
Attachments:
Description Flags
Patch andersca: review+

Description Darin Adler 2020-08-18 11:47:26 PDT
Make some small improvements involving sorting
Comment 1 Darin Adler 2020-08-18 11:51:20 PDT
Created attachment 406797 [details]
Patch
Comment 2 Darin Adler 2020-08-18 13:02:35 PDT
Comment on attachment 406797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406797&action=review

> Source/WebCore/page/PerformanceObserver.cpp:94
> +            if (oldEnd != end) {

Just realized I don’t think this if statement is needed. I think both algorithms below are super-efficient when the ranges are empty.
Comment 3 Darin Adler 2020-08-22 09:13:17 PDT
Committed r266027: <https://trac.webkit.org/changeset/266027>
Comment 4 Radar WebKit Bug Importer 2020-08-22 09:14:13 PDT
<rdar://problem/67617539>