Bug 215610

Summary: Convert runtime flag to setting for lazy image loading
Product: WebKit Reporter: Rob Buis <rbuis>
Component: ImagesAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, clopez, esprehn+autocc, ews-watchlist, gyuyoung.kim, hector_i_lopez, japhet, kondapallykalyan, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216007
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2020-08-18 09:01:24 PDT
Convert runtime flag to setting for lazy image loading.
Attachments
Patch (56.89 KB, patch)
2020-08-18 09:11 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (41.89 KB, patch)
2020-08-27 01:49 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (50.29 KB, patch)
2020-08-27 05:44 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (53.52 KB, patch)
2020-08-27 07:32 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (53.52 KB, patch)
2020-08-27 08:24 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (65.43 KB, patch)
2020-08-28 02:45 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (66.92 KB, patch)
2020-08-28 04:27 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (66.66 KB, patch)
2020-08-28 06:44 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (67.72 KB, patch)
2020-08-29 02:04 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (68.55 KB, patch)
2020-08-31 02:47 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (68.55 KB, patch)
2020-08-31 10:31 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (63.78 KB, patch)
2020-08-31 11:49 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (63.96 KB, patch)
2020-09-01 01:43 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (65.35 KB, patch)
2020-09-10 08:40 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (67.69 KB, patch)
2020-09-14 01:23 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (62.94 KB, patch)
2020-09-14 06:11 PDT, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (61.94 KB, patch)
2020-09-14 07:34 PDT, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (65.49 KB, patch)
2020-09-14 08:55 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (68.62 KB, patch)
2020-09-14 11:12 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (67.42 KB, patch)
2020-09-14 12:46 PDT, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (64.29 KB, patch)
2020-09-14 14:06 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (64.20 KB, patch)
2020-09-15 01:16 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (61.80 KB, patch)
2020-09-15 02:48 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (22) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-08-18 09:11:27 PDT
Created attachment 406789 [details] Patch
EWS Watchlist
Comment 2 2020-08-18 09:12:13 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Radar WebKit Bug Importer
Comment 3 2020-08-25 09:02:13 PDT
<rdar://problem/67740399>
Rob Buis
Comment 4 2020-08-27 01:49:24 PDT
Created attachment 407384 [details] Patch
Rob Buis
Comment 5 2020-08-27 05:44:23 PDT
Created attachment 407391 [details] Patch
Rob Buis
Comment 6 2020-08-27 07:32:31 PDT
Created attachment 407398 [details] Patch
Rob Buis
Comment 7 2020-08-27 08:24:52 PDT
Created attachment 407400 [details] Patch
Rob Buis
Comment 8 2020-08-28 02:45:45 PDT
Created attachment 407457 [details] Patch
Rob Buis
Comment 9 2020-08-28 04:27:43 PDT
Created attachment 407459 [details] Patch
youenn fablet
Comment 10 2020-08-28 06:04:38 PDT
Comment on attachment 407459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407459&action=review > Source/WebKit/Shared/WebPreferences.yaml:-2048 > - category: experimental Why removing the experimental feature?
Rob Buis
Comment 11 2020-08-28 06:44:51 PDT
Created attachment 407466 [details] Patch
EWS
Comment 12 2020-08-28 09:38:57 PDT
Found 1 new test failure: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html
Rob Buis
Comment 13 2020-08-29 02:04:13 PDT
Created attachment 407536 [details] Patch
Rob Buis
Comment 14 2020-08-31 02:47:41 PDT
Created attachment 407595 [details] Patch
EWS
Comment 15 2020-08-31 04:52:02 PDT
Committed r266350: <https://trac.webkit.org/changeset/266350> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407595 [details].
Hector Lopez
Comment 16 2020-08-31 10:22:31 PDT
Reverted r266350 for reason: Revision is causing a constant crash on both macOS and iOS Committed r266358: <https://trac.webkit.org/changeset/266358>
Rob Buis
Comment 17 2020-08-31 10:31:41 PDT
Created attachment 407609 [details] Patch
Simon Fraser (smfr)
Comment 18 2020-08-31 11:03:34 PDT
Comment on attachment 407609 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407609&action=review > Source/WebCore/ChangeLog:8 > + Convert runtime flag to setting for lazy image loading. This is missing the "why".
Rob Buis
Comment 19 2020-08-31 11:26:04 PDT
(In reply to Simon Fraser (smfr) from comment #18) > Comment on attachment 407609 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407609&action=review > > > Source/WebCore/ChangeLog:8 > > + Convert runtime flag to setting for lazy image loading. > > This is missing the "why". Because Sam asked for it :) But I think Sam (partially) ended up implementing it himself: https://bug-215981-attachments.webkit.org/attachment.cgi?id=407610
Rob Buis
Comment 20 2020-08-31 11:49:12 PDT
Created attachment 407613 [details] Patch
Rob Buis
Comment 21 2020-09-01 01:43:30 PDT
Created attachment 407664 [details] Patch
EWS
Comment 22 2020-09-01 12:24:26 PDT
Committed r266408: <https://trac.webkit.org/changeset/266408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407664 [details].
Hector Lopez
Comment 23 2020-09-01 18:56:30 PDT
Reverted r266408 for reason: Revision caused constant crashes on iOS and macOS Committed r266446: <https://trac.webkit.org/changeset/266446>
Simon Fraser (smfr)
Comment 24 2020-09-01 20:48:01 PDT
Why did EWS not show crashes?
Rob Buis
Comment 25 2020-09-01 22:37:42 PDT
(In reply to Simon Fraser (smfr) from comment #24) > Why did EWS not show crashes? What Simon says. You have to give a bit more information about this, the bots are green and I can't reproduce any problems locally. Is this maybe related to a certain macOs version? Any backtraces?
youenn fablet
Comment 26 2020-09-02 00:10:55 PDT
This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007
Rob Buis
Comment 27 2020-09-02 00:45:04 PDT
(In reply to youenn fablet from comment #26) > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 Thanks Youenn. I was aware of this problem and added a line to skip it for now in the patches that landed: +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ Skip ] Is skipping not the right thing? Should it be marked as Crash?
youenn fablet
Comment 28 2020-09-02 00:49:29 PDT
(In reply to Rob Buis from comment #27) > (In reply to youenn fablet from comment #26) > > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 > > Thanks Youenn. I was aware of this problem and added a line to skip it for > now in the patches that landed: > +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img- > element/image-loading-lazy-slow.html [ Skip ] > > Is skipping not the right thing? Should it be marked as Crash? We should probably first understand why it is crashing before skipping it. Can you repro the issue for this test? If some other test is crashing, it might be some similar test. Hector might be able to provide some more precise information later.
youenn fablet
Comment 29 2020-09-03 01:48:02 PDT
*** Bug 216007 has been marked as a duplicate of this bug. ***
Rob Buis
Comment 30 2020-09-04 07:38:54 PDT
(In reply to youenn fablet from comment #28) > (In reply to Rob Buis from comment #27) > > (In reply to youenn fablet from comment #26) > > > This is most probably https://bugs.webkit.org/show_bug.cgi?id=216007 > > > > Thanks Youenn. I was aware of this problem and added a line to skip it for > > now in the patches that landed: > > +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img- > > element/image-loading-lazy-slow.html [ Skip ] > > > > Is skipping not the right thing? Should it be marked as Crash? > > We should probably first understand why it is crashing before skipping it. > Can you repro the issue for this test? > > If some other test is crashing, it might be some similar test. > Hector might be able to provide some more precise information later. Yes, I was able to repro and fix is here: https://bugs.webkit.org/show_bug.cgi?id=215998 I think it is cleaner to keep the fix separate since this bug was just about converting, not really changing behaviour.
Rob Buis
Comment 31 2020-09-10 08:40:21 PDT
Created attachment 408448 [details] Patch
Rob Buis
Comment 32 2020-09-14 01:23:05 PDT
Created attachment 408688 [details] Patch
Rob Buis
Comment 33 2020-09-14 02:57:50 PDT
@youenn I upstreamed some of the reftest-wait tests changes to: https://github.com/web-platform-tests/wpt/pull/25513
Rob Buis
Comment 34 2020-09-14 06:11:44 PDT
Created attachment 408704 [details] Patch
Rob Buis
Comment 35 2020-09-14 07:34:06 PDT
Created attachment 408705 [details] Patch
Rob Buis
Comment 36 2020-09-14 08:55:56 PDT
Created attachment 408707 [details] Patch
Rob Buis
Comment 37 2020-09-14 11:12:26 PDT
Created attachment 408727 [details] Patch
Rob Buis
Comment 38 2020-09-14 12:46:28 PDT
Created attachment 408736 [details] Patch
Rob Buis
Comment 39 2020-09-14 14:06:19 PDT
Created attachment 408745 [details] Patch
Rob Buis
Comment 40 2020-09-15 01:16:01 PDT
Created attachment 408800 [details] Patch
Rob Buis
Comment 41 2020-09-15 02:48:21 PDT
Created attachment 408808 [details] Patch
EWS
Comment 42 2020-09-15 04:36:11 PDT
Committed r267083: <https://trac.webkit.org/changeset/267083> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408808 [details].
Note You need to log in before you can comment on or make changes to this bug.