Bug 215596

Summary: [Mac] Unhandled keyDown: events cause a system beep in full screen mode
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2020-08-17 17:02:34 PDT
[Mac] Unhandled keyDown: events cause a system beep in full screen mode
Attachments
Patch (1.34 KB, patch)
2020-08-17 17:05 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.67 KB, patch)
2020-08-18 08:38 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-08-17 17:04:29 PDT
<rdar://problem/65823962>
Jer Noble
Comment 2 2020-08-17 17:05:19 PDT
Created attachment 406754 [details] Patch
Darin Adler
Comment 3 2020-08-17 17:30:38 PDT
Comment on attachment 406754 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406754&action=review > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229 > + UNUSED_PARAM(eventMethod); Comment would be welcome.
Jer Noble
Comment 4 2020-08-18 08:33:03 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 406754 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406754&action=review > > > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229 > > + UNUSED_PARAM(eventMethod); > > Comment would be welcome. Sure thing. I wavered on whether to add a "why" comment here.
Jer Noble
Comment 5 2020-08-18 08:38:36 PDT
Created attachment 406787 [details] Patch for landing
EWS
Comment 6 2020-08-18 09:01:45 PDT
Committed r265816: <https://trac.webkit.org/changeset/265816> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406787 [details].
Note You need to log in before you can comment on or make changes to this bug.