Bug 21556

Summary: non-ASCII digits are allowed in places where only ASCII should be
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch sam: review+

Darin Adler
Reported 2008-10-12 11:12:21 PDT
We shouldn't have isDigit and digitValue in our Unicode class, because there's no context where we want to support arbitrary Unicode digits. All the places we support digits they need to be ASCII digits only.
Attachments
patch (120.32 KB, patch)
2008-10-12 13:28 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch (58.42 KB, patch)
2008-10-12 13:29 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-10-12 11:33:31 PDT
My plan is to remove unused functions from our Unicode headers and also remove used functions that are being used when an ASCII function should be used instead. - digitValue is never used except where it should be ASCII-only - isDigit is never used except where it should be ASCII-only - isFormatChar is unused As far as I can tell, the other functions are used correctly, so I won't touch them for now.
Darin Adler
Comment 2 2008-10-12 13:28:01 PDT
Created attachment 24309 [details] patch
Darin Adler
Comment 3 2008-10-12 13:29:37 PDT
Created attachment 24310 [details] patch Oops, included unrelated changes by accident.
Sam Weinig
Comment 4 2008-10-12 15:25:14 PDT
Comment on attachment 24310 [details] patch r=me, but I think you should land the cleanups separately.
Darin Adler
Comment 5 2008-10-12 15:51:40 PDT
http://trac.webkit.org/changeset/37531
Note You need to log in before you can comment on or make changes to this bug.