Bug 215513

Summary: Fix bad check in AudioBufferSourceNode::renderFromBuffer()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-08-14 10:35:29 PDT
Fix bad check in AudioBufferSourceNode::renderFromBuffer() that is causing us to incorrectly output silence and failing many WPT tests.
Attachments
Patch (69.06 KB, patch)
2020-08-14 10:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (69.05 KB, patch)
2020-08-14 10:46 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-14 10:38:06 PDT
Created attachment 406602 [details] Patch
Darin Adler
Comment 2 2020-08-14 10:43:43 PDT
Comment on attachment 406602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406602&action=review > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp:249 > + if (fabs(pitchRate) > virtualDeltaFrames) std::abs is better than fabs
Chris Dumez
Comment 3 2020-08-14 10:46:59 PDT
Created attachment 406605 [details] Patch
EWS
Comment 4 2020-08-14 11:27:15 PDT
Committed r265683: <https://trac.webkit.org/changeset/265683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406605 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-14 11:28:19 PDT
<rdar://problem/67085393>
Note You need to log in before you can comment on or make changes to this bug.