Bug 215494

Summary: Web Inspector: Assertion Failed: Appended a string with newlines. This breaks the source map.
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2020-08-13 23:39:39 PDT
# STEPS TO REPRODUCE 1. inspect any page with C-style comments
Attachments
Patch (1.71 KB, patch)
2020-08-13 23:42 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (55.10 KB, patch)
2020-08-14 15:31 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (55.86 KB, patch)
2020-08-14 16:53 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-08-13 23:42:53 PDT
Created attachment 406574 [details] Patch
Joseph Pecoraro
Comment 2 2020-08-14 10:50:08 PDT
Comment on attachment 406574 [details] Patch We should have a test for this, no?
Devin Rousso
Comment 3 2020-08-14 15:15:14 PDT
(In reply to Joseph Pecoraro from comment #2) > Comment on attachment 406574 [details] > Patch > > We should have a test for this, no? We have formatting tests that cover this case, but not source map tests. I'll add one.
Devin Rousso
Comment 4 2020-08-14 15:31:58 PDT
Created attachment 406628 [details] Patch
Joseph Pecoraro
Comment 5 2020-08-14 16:21:32 PDT
Comment on attachment 406628 [details] Patch Nice!
Devin Rousso
Comment 6 2020-08-14 16:53:01 PDT
Created attachment 406635 [details] Patch
EWS
Comment 7 2020-08-14 18:24:07 PDT
Committed r265724: <https://trac.webkit.org/changeset/265724> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406635 [details].
Radar WebKit Bug Importer
Comment 8 2020-08-14 18:25:18 PDT
<rdar://problem/67111999>
Note You need to log in before you can comment on or make changes to this bug.