Bug 215494 - Web Inspector: Assertion Failed: Appended a string with newlines. This breaks the source map.
Summary: Web Inspector: Assertion Failed: Appended a string with newlines. This breaks...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-13 23:39 PDT by Devin Rousso
Modified: 2020-08-14 18:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2020-08-13 23:42 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (55.10 KB, patch)
2020-08-14 15:31 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (55.86 KB, patch)
2020-08-14 16:53 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-08-13 23:39:39 PDT 
# STEPS TO REPRODUCE
1. inspect any page with C-style comments
Comment 1 Devin Rousso 2020-08-13 23:42:53 PDT 
Created attachment 406574 [details]
Patch
Comment 2 Joseph Pecoraro 2020-08-14 10:50:08 PDT 
Comment on attachment 406574 [details]
Patch

We should have a test for this, no?
Comment 3 Devin Rousso 2020-08-14 15:15:14 PDT 
(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 406574 [details]
> Patch
> 
> We should have a test for this, no?

We have formatting tests that cover this case, but not source map tests.  I'll add one.
Comment 4 Devin Rousso 2020-08-14 15:31:58 PDT 
Created attachment 406628 [details]
Patch
Comment 5 Joseph Pecoraro 2020-08-14 16:21:32 PDT 
Comment on attachment 406628 [details]
Patch

Nice!
Comment 6 Devin Rousso 2020-08-14 16:53:01 PDT 
Created attachment 406635 [details]
Patch
Comment 7 EWS 2020-08-14 18:24:07 PDT 
Committed r265724: <https://trac.webkit.org/changeset/265724>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406635 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-14 18:25:18 PDT 
<rdar://problem/67111999>