| Summary: | VoiceOver not able to invoke play button on some web sites. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andres Gonzalez
2020-08-13 18:22:15 PDT
Created attachment 406563 [details]
Patch
For instance, the play buttons in https://threema.ch/en/faq/callsounds. Committed r265645: <https://trac.webkit.org/changeset/265645> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406563 [details]. Comment on attachment 406563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90 > + for (auto eventName : touchEventNames) { This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn. Comment on attachment 406563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review >> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90 >> + for (auto eventName : touchEventNames) { > > This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn. Because we’re using reference_wrapper that might require adding a * below. But it will make things a tiny bit more efficient. |