Bug 215466

Summary: [WebGL2] Skip buggy conformance tests
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: New BugsAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kbr, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Darpinian
Reported 2020-08-13 15:05:44 PDT
[WebGL2] Skip buggy conformance tests
Attachments
Patch (2.54 KB, patch)
2020-08-13 15:06 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-08-13 15:06:38 PDT
Created attachment 406546 [details] Patch
James Darpinian
Comment 2 2020-08-13 15:10:01 PDT
Comment on attachment 406546 [details] Patch This should fix the deqp bot so it finishes a complete run every time instead of stopping halfway. https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-WebGL-Tests
EWS
Comment 3 2020-08-14 15:30:38 PDT
Committed r265710: <https://trac.webkit.org/changeset/265710> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406546 [details].
Radar WebKit Bug Importer
Comment 4 2020-08-14 15:31:22 PDT
<rdar://problem/67102040>
Kimmo Kinnunen
Comment 5 2021-03-09 03:12:33 PST
Do we remember why the LayoutTests/webgl/TestExpectations added tests without deqp prefix? I'd imagine those skips would be added to LayoutTests/TestExpectations
Kenneth Russell
Comment 6 2021-03-09 20:15:17 PST
Sorry, I'm not sure. Agree it's confusing that most of the webgl/ expectations are in LayoutTests/TestExpectations and some in LayoutTests/webgl/TestExpectations . Maybe some of the WebKit EWS bots are configured to run or ignore some of these tests / TestExpectations and that's why they're factored this way?
Note You need to log in before you can comment on or make changes to this bug.