Bug 215453

Summary: REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted"
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kangil.han, macpherson, menard, peng.liu6, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=268130
Bug Depends on:    
Bug Blocks: 211003    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-08-13 09:20:03 PDT
Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted". This is a regression from <https://trac.webkit.org/changeset/260684/webkit>.
Attachments
Patch (14.85 KB, patch)
2020-08-13 10:20 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.29 KB, patch)
2020-08-13 11:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.40 KB, patch)
2020-08-13 11:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.24 KB, patch)
2020-08-13 11:56 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-13 09:20:11 PDT
<rdar://problem/66136673>
Chris Dumez
Comment 2 2020-08-13 10:20:25 PDT
Created attachment 406522 [details] Patch
Peng Liu
Comment 3 2020-08-13 10:37:14 PDT
Comment on attachment 406522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review > Source/WebCore/ChangeLog:12 > + events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is "silence" here means "drop" messages/events?
Chris Dumez
Comment 4 2020-08-13 10:38:53 PDT
(In reply to Peng Liu from comment #3) > Comment on attachment 406522 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406522&action=review > > > Source/WebCore/ChangeLog:12 > > + events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is > > "silence" here means "drop" messages/events? Yes, those messages were getting dropped indeed.
Tim Horton
Comment 5 2020-08-13 11:16:38 PDT
Comment on attachment 406522 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review > Source/WebKit/WebProcess/WebPage/WebPage.h:1734 > + void setIsDoingSnapshotSequence(bool); "IsDoing" sounds a bit funny, and "snapshot sequence" sounds a bit vague (what kind of snapshot? we do so many kinds). isSnapshottingForApplicationSuspension, maybe?
Geoffrey Garen
Comment 6 2020-08-13 11:20:51 PDT
> isSnapshottingForApplicationSuspension, maybe? isTakingSnapshotForApplicationSuspension?
Tim Horton
Comment 7 2020-08-13 11:23:46 PDT
(In reply to Geoffrey Garen from comment #6) > > isSnapshottingForApplicationSuspension, maybe? > > isTakingSnapshotForApplicationSuspension? Sure!
Chris Dumez
Comment 8 2020-08-13 11:43:42 PDT
Created attachment 406525 [details] Patch
Chris Dumez
Comment 9 2020-08-13 11:53:06 PDT
Created attachment 406527 [details] Patch
Chris Dumez
Comment 10 2020-08-13 11:53:35 PDT
Comment on attachment 406527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406527&action=review > Source/WebCore/page/Quirks.cpp:648 > +#if PLATFORM(IOS) Added this check since we only need those quirks on iOS.
Chris Dumez
Comment 11 2020-08-13 11:56:45 PDT
Created attachment 406528 [details] Patch
EWS
Comment 12 2020-08-13 14:50:36 PDT
Committed r265623: <https://trac.webkit.org/changeset/265623> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406528 [details].
Note You need to log in before you can comment on or make changes to this bug.