Bug 215449

Summary: [ews] Improve wording for test failure email
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jbedard: review+

Aakash Jain
Reported 2020-08-13 07:17:23 PDT
Improve wording for test failure emails by EWS.
Attachments
Patch (3.02 KB, patch)
2020-08-13 07:20 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-08-13 07:20:15 PDT
Created attachment 406512 [details] Patch
Jonathan Bedard
Comment 2 2020-08-13 08:45:08 PDT
Comment on attachment 406512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2159 > + email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id) Should we link the patch ID to bugzilla?
Aakash Jain
Comment 3 2020-08-13 08:57:35 PDT
Comment on attachment 406512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:2159 >> + email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id) > > Should we link the patch ID to bugzilla? Good idea, let me do that in subsequent patch.
Aakash Jain
Comment 4 2020-08-13 08:59:37 PDT
Committed r265609: <https://trac.webkit.org/changeset/265609>
Radar WebKit Bug Importer
Comment 5 2020-08-13 09:00:26 PDT
<rdar://problem/66994254>
Aakash Jain
Comment 6 2020-08-13 09:34:52 PDT
> > Should we link the patch ID to bugzilla? > > Good idea, let me do that in subsequent patch. Doing it in Bug 215455.
Note You need to log in before you can comment on or make changes to this bug.