Bug 215443

Summary: Move scroll / overflow handling out of RenderLayer
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: Layout and RenderingAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aboxhall, annulen, apinheiro, bfulgham, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jcraig, jdiggs, kangil.han, kondapallykalyan, mifenton, mkwst, mmaxfield, pdr, ryuan.choi, samuel_white, sergio, simon.fraser, zalan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=60305
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Nikolas Zimmermann
Reported 2020-08-13 01:04:25 PDT
Per recent discussions between Igalia / Apple, it would be nice to split up RenderLayer into a lean, base class and a derived class which contains all scroll / overflow handling ("RenderLayerScrollable"). I propose to first move all scroll / overflow handling from RenderLayer to RenderLayerScrollable, and as next step only create RenderLayerScrollable objects if needed -- this should be a performance progression for many scenarios. I'll upload an initial draft patch to discuss the design.
Attachments
Patch (320.21 KB, patch)
2020-08-13 01:11 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch (317.65 KB, patch)
2020-08-13 07:36 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch (319.64 KB, patch)
2020-08-13 14:54 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2020-08-13 01:11:40 PDT
Created attachment 406501 [details] Patch
Nikolas Zimmermann
Comment 2 2020-08-13 01:14:12 PDT
Eww 320k :-( The majority of the patch size is moving methods 1:1, unmodified, from RenderLayer to RenderLayerScrollable. @smfr, would be nice if you could have a look at the general design. I'm open for improvements, as always!
Nikolas Zimmermann
Comment 3 2020-08-13 07:35:55 PDT
Needs some iterations, I likely missed win/ios/mac specific build fixes.
Nikolas Zimmermann
Comment 4 2020-08-13 07:36:58 PDT
Created attachment 406515 [details] Patch
Nikolas Zimmermann
Comment 5 2020-08-13 14:54:15 PDT
Created attachment 406545 [details] Patch
Simon Fraser (smfr)
Comment 6 2020-08-13 15:01:10 PDT
Please dup this bug to 60305 and continue work there.
Nikolas Zimmermann
Comment 7 2020-08-13 16:05:09 PDT
*** This bug has been marked as a duplicate of bug 60305 ***
Note You need to log in before you can comment on or make changes to this bug.