Bug 215440

Summary: Add settings for Copy WebKit Permalink
Product: WebKit Reporter: Devin Rousso <hi>
Component: Tools / TestsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, hi, joepeck, keith_miller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215796    
Attachments:
Description Flags
Patch
dbates: review+
Patch none

Devin Rousso
Reported 2020-08-12 21:27:55 PDT
.
Attachments
Patch (6.18 KB, patch)
2020-08-12 21:34 PDT, Devin Rousso 		dbates: review+
DetailsFormatted DiffDiff
Patch (6.18 KB, patch)
2020-08-12 22:21 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-08-12 21:34:03 PDT
Created attachment 406495 [details] Patch
Devin Rousso
Comment 2 2020-08-12 21:47:40 PDT
Comment on attachment 406495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3 > + "include_revision": true, I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality.
Daniel Bates
Comment 3 2020-08-12 22:03:41 PDT
Comment on attachment 406495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review Patch looks good. > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:38 > +class Settings: Ok as is. Consider inherit from object. >> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3 >> + "include_revision": true, > > I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality. 👍
Devin Rousso
Comment 4 2020-08-12 22:21:42 PDT
Created attachment 406498 [details] Patch
EWS
Comment 5 2020-08-12 23:07:01 PDT
Committed r265601: <https://trac.webkit.org/changeset/265601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406498 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-12 23:07:17 PDT
<rdar://problem/66963933>
Note You need to log in before you can comment on or make changes to this bug.