Bug 21542

Summary: CSS NS resolvers are no longer part of the spec
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: CSSAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Minor CC: abarth, lachlan.hunt, sam
Priority: P2 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://dev.w3.org/2006/webapi/selectors-api/#namespace
Attachments:
Description Flags
Removes NS Resolver functionality from Node.cpp and friends sam: review+

Dimitri Glazkov (Google)
Reported 2008-10-10 20:27:02 PDT
Since the NS resolvers were recently removed from the spec, I thought I'd take on cleaning up the code.
Attachments
Removes NS Resolver functionality from Node.cpp and friends (205.68 KB, patch)
2008-10-13 07:37 PDT, Dimitri Glazkov (Google) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2008-10-10 20:29:49 PDT
Removing them should be quite trivial, the trick is what to do with the tests :).
Dimitri Glazkov (Google)
Comment 2 2008-10-13 07:37:30 PDT
Created attachment 24313 [details] Removes NS Resolver functionality from Node.cpp and friends Struggled a bit figuring out how to produce a diff for the patch using git. Aye caramba, I have much to learn :)
Sam Weinig
Comment 3 2008-10-13 10:22:30 PDT
Comment on attachment 24313 [details] Removes NS Resolver functionality from Node.cpp and friends + // throw a NAMESPACE_ERR if the selector includes any namespace prefixes. Should use a capital T for throw, at least to be consistent. How sad. That code was so fun to write :(. r=me
Adam Barth
Comment 4 2008-10-14 01:24:28 PDT
I would land this, but its too big and scary.
Sam Weinig
Comment 5 2008-10-14 08:38:59 PDT
I'll land this.
Sam Weinig
Comment 6 2008-10-14 12:55:58 PDT
Landed in r37590.
Note You need to log in before you can comment on or make changes to this bug.