| Summary: | Add support for suspending / resuming an OfflineAudioContext | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215481 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 212611 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2020-08-12 10:43:08 PDT
Created attachment 406464 [details]
WIP Patch
Created attachment 406547 [details]
Patch
Created attachment 406551 [details]
Patch
Created attachment 406552 [details]
Patch
Comment on attachment 406552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406552&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:659 > // Don't allow regular lock in real-time audio thread. This comment is not accurate when shouldAllowLockingOnAudioThread == ShouldAllowLockingOnAudioThread::Yes > Source/WebCore/Modules/webaudio/BaseAudioContext.h:208 > + enum class ShouldAllowLockingOnAudioThread { No, Yes }; It seems like there should be a comment here with a stern warning about using this. Created attachment 406615 [details]
Patch
Committed r265701: <https://trac.webkit.org/changeset/265701> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406615 [details]. |