Bug 215417

Summary: Add support for suspending / resuming an OfflineAudioContext
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215481
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-08-12 10:43:08 PDT
Add support for suspending / resuming an OfflineAudioContext.
Attachments
WIP Patch (22.13 KB, patch)
2020-08-12 10:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (182.71 KB, patch)
2020-08-13 15:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (185.65 KB, patch)
2020-08-13 16:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (185.69 KB, patch)
2020-08-13 16:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (253.24 KB, patch)
2020-08-14 12:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-12 10:44:02 PDT
Created attachment 406464 [details] WIP Patch
Chris Dumez
Comment 2 2020-08-13 15:26:49 PDT
Created attachment 406547 [details] Patch
Chris Dumez
Comment 3 2020-08-13 16:01:56 PDT
Created attachment 406551 [details] Patch
Chris Dumez
Comment 4 2020-08-13 16:10:04 PDT
Created attachment 406552 [details] Patch
Eric Carlson
Comment 5 2020-08-14 11:31:55 PDT
Comment on attachment 406552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406552&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:659 > // Don't allow regular lock in real-time audio thread. This comment is not accurate when shouldAllowLockingOnAudioThread == ShouldAllowLockingOnAudioThread::Yes > Source/WebCore/Modules/webaudio/BaseAudioContext.h:208 > + enum class ShouldAllowLockingOnAudioThread { No, Yes }; It seems like there should be a comment here with a stern warning about using this.
Chris Dumez
Comment 6 2020-08-14 12:41:10 PDT
Created attachment 406615 [details] Patch
EWS
Comment 7 2020-08-14 13:27:12 PDT
Committed r265701: <https://trac.webkit.org/changeset/265701> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406615 [details].
Radar WebKit Bug Importer
Comment 8 2020-08-14 13:28:23 PDT
<rdar://problem/67093628>
Note You need to log in before you can comment on or make changes to this bug.