Bug 215378

Summary: Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2020-08-11 09:02:26 PDT
Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
Comment 1 youenn fablet 2020-08-11 09:03:10 PDT
<rdar://problem/66788144>
Comment 2 youenn fablet 2020-08-11 09:04:06 PDT
Created attachment 406384 [details]
Patch
Comment 3 Eric Carlson 2020-08-11 09:07:03 PDT
Comment on attachment 406384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review

> Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722
> +            return;

Nit: the indentation is strange.
Comment 4 youenn fablet 2020-08-11 09:18:07 PDT
Comment on attachment 406384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review

>> Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722
>> +            return;
> 
> Nit: the indentation is strange.

Ah, I used space but this file is using tabs...
Comment 5 youenn fablet 2020-08-11 09:20:17 PDT
Created attachment 406385 [details]
Patch
Comment 6 EWS 2020-08-11 10:06:35 PDT
Committed r265500: <https://trac.webkit.org/changeset/265500>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406385 [details].