Bug 215320

Summary: Return values of FontDatabase::collectionForFamily are not thread safe
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, ews-watchlist, mmaxfield, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2020-08-10 05:12:40 PDT
This results in a crash under findClosestFont: 50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) <== 50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) 50 WebCore: WebCore::FontCache::createFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities) 50 WebCore: WebCore::FontCache::getCachedFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool) 50 WebCore: WebCore::FontCache::fontForFamily(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool) 50 WebCore: WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&) 50 WebCore: WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) 50 WebCore: WebCore::FontCascadeFonts::realizeFallbackRangesAt(WebCore::FontCascadeDescription const&, unsigned int) 50 WebCore: WebCore::FontCascadeFonts::primaryFont(WebCore::FontCascadeDescription const&)
Attachments
patch (3.25 KB, patch)
2020-08-10 05:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-08-10 05:13:55 PDT
<rdar://problem/66502539>
Antti Koivisto
Comment 2 2020-08-10 05:26:20 PDT
Created attachment 406293 [details] patch
EWS
Comment 3 2020-08-10 09:41:52 PDT
Committed r265432: <https://trac.webkit.org/changeset/265432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406293 [details].
Note You need to log in before you can comment on or make changes to this bug.