Bug 21524

Summary:

Remove race condition in fast/encoding/script-in-head.html

Product:

WebKit

Reporter:

Pam Greene (IRC:pamg) <pam>

Component:

Page Loading

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fixes test	darin: review+

Description Pam Greene (IRC:pamg) 2008-10-10 10:46:43 PDT

The fast/encoding/script-in-head.html test has a race condition: the page may be dumped before the dynamically generated <script> tag is executed.  Likewise, the document.write() may be buffered, leading to unreliable results.  (Buffering document.write() may be a bug itself, but since it's not related to what this is testing, we should work around it here if we can.)

Comment 1 Pam Greene (IRC:pamg) 2008-10-10 10:49:00 PDT

Created attachment 24266 [details]
Fixes test

Expected results are unchanged.

Comment 2 Darin Adler 2008-10-10 14:04:40 PDT

Comment on attachment 24266 [details]
Fixes test

r=me

Comment 3 Adam Barth 2008-10-12 13:45:45 PDT

I'll land this.

Comment 4 Adam Barth 2008-10-12 18:58:48 PDT

Fixed in r37547.