Bug 21524

Summary: Remove race condition in fast/encoding/script-in-head.html
Product: WebKit Reporter: Pam Greene (IRC:pamg) <pam>
Component: Page LoadingAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Fixes test darin: review+

Pam Greene (IRC:pamg)
Reported 2008-10-10 10:46:43 PDT
The fast/encoding/script-in-head.html test has a race condition: the page may be dumped before the dynamically generated <script> tag is executed. Likewise, the document.write() may be buffered, leading to unreliable results. (Buffering document.write() may be a bug itself, but since it's not related to what this is testing, we should work around it here if we can.)
Attachments
Fixes test (1.68 KB, patch)
2008-10-10 10:49 PDT, Pam Greene (IRC:pamg) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1 2008-10-10 10:49:00 PDT
Created attachment 24266 [details] Fixes test Expected results are unchanged.
Darin Adler
Comment 2 2008-10-10 14:04:40 PDT
Comment on attachment 24266 [details] Fixes test r=me
Adam Barth
Comment 3 2008-10-12 13:45:45 PDT
I'll land this.
Adam Barth
Comment 4 2008-10-12 18:58:48 PDT
Fixed in r37547.
Note You need to log in before you can comment on or make changes to this bug.