Bug 215219

Summary: [ews] Add method to send email notifications to patch author for build failure
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215231
https://bugs.webkit.org/show_bug.cgi?id=215776
Bug Depends on:    
Bug Blocks: 215220    
Attachments:
Description Flags
Patch
jbedard: review+
sample email none

Aakash Jain
Reported 2020-08-06 09:02:02 PDT
Add method to send email notifications to patch author for build failures in EWS.
Attachments
Patch (3.23 KB, patch)
2020-08-06 09:04 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
sample email (148.36 KB, image/png)
2020-08-06 09:40 PDT, Aakash Jain 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-08-06 09:04:56 PDT
Created attachment 406085 [details] Patch
Aakash Jain
Comment 2 2020-08-06 09:06:13 PDT
This patch only adds the ability to send emails for build failures introduced by patch, but doesn't enable the email sending yet.
Aakash Jain
Comment 3 2020-08-06 09:40:27 PDT
Created attachment 406087 [details] sample email
Aakash Jain
Comment 4 2020-08-06 09:41:22 PDT
> sample email Based on failure in https://ews-build.webkit.org/#/builders/8/builds/31968
Jonathan Bedard
Comment 5 2020-08-06 11:21:56 PDT
Comment on attachment 406085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406085&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1446 > + def send_email_for_new_build_failure(self): We probably need some smarts so we don't email engineers about patches marked obsolete, and maybe even to avoid sending emails if a patch is not marked for review.
Aakash Jain
Comment 6 2020-08-06 11:38:10 PDT
Committed r265341: <https://trac.webkit.org/changeset/265341>
Radar WebKit Bug Importer
Comment 7 2020-08-06 11:39:41 PDT
<rdar://problem/66637362>
Note You need to log in before you can comment on or make changes to this bug.