Bug 215200

Summary: MediaElementAudioSourceNode interface should have a constructor
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://webaudio.github.io/web-audio-api/#mediaelementaudiosourcenode
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch youennf: review+

Chris Dumez
Reported 2020-08-05 16:24:03 PDT
MediaElementAudioSourceNode interface should have a constructor: - https://webaudio.github.io/web-audio-api/#mediaelementaudiosourcenode
Attachments
Patch (41.90 KB, patch)
2020-08-05 17:29 PDT, Chris Dumez 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-05 17:29:17 PDT
Created attachment 406059 [details] Patch
youenn fablet
Comment 2 2020-08-06 01:40:25 PDT
Comment on attachment 406059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406059&action=review > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55 > + context.lazyInitialize(); We could move this after the next if check to keep existing behavior and be more lazy.
Chris Dumez
Comment 3 2020-08-06 09:18:09 PDT
Committed r265330: <https://trac.webkit.org/changeset/265330>
Chris Dumez
Comment 4 2020-08-06 09:18:26 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 406059 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406059&action=review > > > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55 > > + context.lazyInitialize(); > > We could move this after the next if check to keep existing behavior and be > more lazy. Fixed before landing.
Radar WebKit Bug Importer
Comment 5 2020-08-06 09:19:43 PDT
<rdar://problem/66630110>
Note You need to log in before you can comment on or make changes to this bug.