Bug 215187

Summary: Add a createWebArchiveData from a custom scheme API test
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2020-08-05 13:36:43 PDT
Add a createWebArchiveData from a custom scheme API test
Attachments
Patch (9.93 KB, patch)
2020-08-05 13:40 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.54 KB, patch)
2020-08-05 14:39 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.54 KB, patch)
2020-08-05 14:47 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.63 KB, patch)
2020-08-05 14:53 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.62 KB, patch)
2020-08-05 15:02 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.72 KB, patch)
2020-08-05 15:23 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-08-05 13:40:44 PDT
Created attachment 406034 [details] Patch
Tim Horton
Comment 2 2020-08-05 13:42:44 PDT
Comment on attachment 406034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406034&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:72 > + static bool done = false; __block instead of static?
Brady Eidson
Comment 3 2020-08-05 14:39:41 PDT
Created attachment 406040 [details] Patch
Brady Eidson
Comment 4 2020-08-05 14:47:45 PDT
Created attachment 406042 [details] Patch
Brady Eidson
Comment 5 2020-08-05 14:53:12 PDT
Created attachment 406045 [details] Patch
Brady Eidson
Comment 6 2020-08-05 15:02:34 PDT
Created attachment 406046 [details] Patch
Brady Eidson
Comment 7 2020-08-05 15:23:18 PDT
Created attachment 406049 [details] Patch
EWS
Comment 8 2020-08-05 16:20:03 PDT
Committed r265310: <https://trac.webkit.org/changeset/265310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406049 [details].
Radar WebKit Bug Importer
Comment 9 2020-08-05 16:21:18 PDT
<rdar://problem/66599058>
Darin Adler
Comment 10 2020-08-08 11:47:25 PDT
Comment on attachment 406046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406046&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:93 > + [webView loadData:archiveData.get() MIMEType:(NSString *)kUTTypeArchive characterEncodingName:@"utf-8" baseURL:[NSURL URLWithString:@"about:blank"]]; iOS build says: CreateWebArchive.mm:93:62: error: use of undeclared identifier 'kUTTypeArchive'
Note You need to log in before you can comment on or make changes to this bug.