Bug 215179

Summary: r264813 breaks Make runner on remote devices
Product: WebKit Reporter: Caio Lima <ticaiolima>
Component: JavaScriptCoreAssignee: Caio Lima <ticaiolima>
Status: RESOLVED FIXED    
Severity: Normal CC: saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Caio Lima
Reported 2020-08-05 11:49:11 PDT
The problem is that changes introduced by r264813 sets `LD_LIBRARY_PATH` wrongly. This can cause a variety of issues depending on configuration fo the remote runner.
Attachments
Patch (1.41 KB, patch)
2020-08-05 12:05 PDT, Caio Lima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Lima
Comment 1 2020-08-05 12:05:41 PDT
Created attachment 406021 [details] Patch
Caio Lima
Comment 2 2020-08-05 16:48:47 PDT
Comment on attachment 406021 [details] Patch Win failure is very likely unrelated, since this change is Linux specific. Thank you for the review!
EWS
Comment 3 2020-08-05 16:54:50 PDT
Committed r265312: <https://trac.webkit.org/changeset/265312> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406021 [details].
Radar WebKit Bug Importer
Comment 4 2020-08-05 16:55:17 PDT
<rdar://problem/66600583>
Note You need to log in before you can comment on or make changes to this bug.