Bug 215179

Summary:

r264813 breaks Make runner on remote devices

Product:

WebKit

Reporter:

Caio Lima <ticaiolima>

Component:

JavaScriptCore

Assignee:

Caio Lima <ticaiolima>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Caio Lima 2020-08-05 11:49:11 PDT

The problem is that changes introduced by r264813 sets `LD_LIBRARY_PATH` wrongly. This can cause a variety of issues depending on configuration fo the remote runner.

Comment 1 Caio Lima 2020-08-05 12:05:41 PDT

Created attachment 406021 [details]
Patch

Comment 2 Caio Lima 2020-08-05 16:48:47 PDT

Comment on attachment 406021 [details]
Patch

Win failure is very likely unrelated, since this change is Linux specific. Thank you for the review!

Comment 3 EWS 2020-08-05 16:54:50 PDT

Committed r265312: <https://trac.webkit.org/changeset/265312>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406021 [details].

Comment 4 Radar WebKit Bug Importer 2020-08-05 16:55:17 PDT

<rdar://problem/66600583>