Bug 215169

Summary: Add constructor to ConvolverNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://webaudio.github.io/web-audio-api/#ConvolverNode
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-08-05 09:15:28 PDT
Add constructor to ConvolverNode: - https://webaudio.github.io/web-audio-api/#ConvolverNode
Attachments
Patch (41.31 KB, patch)
2020-08-05 10:50 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (41.93 KB, patch)
2020-08-05 11:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (41.96 KB, patch)
2020-08-05 11:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-05 10:50:11 PDT
Created attachment 406013 [details] Patch
Eric Carlson
Comment 2 2020-08-05 11:04:43 PDT
Comment on attachment 406013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406013&action=review > Source/WebCore/Modules/webaudio/ConvolverNode.cpp:210 > + return Exception { NotSupportedError, "ConvolverNode's channel count cannot greater than 2"_s }; s/channel count cannot greater than 2/channel count cannot be greater than 2/ > Source/WebCore/Modules/webaudio/ConvolverNode.idl:3 > + * Copyright (C) 2020, Apple Inc. All rights reserved. Is there any reason to update this copyright but not the .cpp or .h files?
Chris Dumez
Comment 3 2020-08-05 11:32:28 PDT
Created attachment 406017 [details] Patch
Chris Dumez
Comment 4 2020-08-05 11:40:21 PDT
Created attachment 406018 [details] Patch
EWS
Comment 5 2020-08-05 12:23:10 PDT
Committed r265298: <https://trac.webkit.org/changeset/265298> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406018 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-05 12:24:17 PDT
<rdar://problem/66587740>
Note You need to log in before you can comment on or make changes to this bug.