Bug 215166 – Add a quota delegate test for miniaturized/deminiaturized pages

• Component: Service Workers
• Status: RESOLVED FIXED

[youenn fablet]

Add a quota delegate test for miniaturized/deminiaturized pages

[youenn fablet]

Created attachment 405996 [details]
Patch

[youenn fablet]

Created attachment 406006 [details]
Patch

[youenn fablet]

I added some logging in case this test also fails in Debug Mac bots.

[youenn fablet]

Ping review

[Alex Christensen]

Comment on attachment 406006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406006&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:138
> +-(String)receivedMessage {

space before (, { should be on next line.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278
> +    NSLog(@"QuotaDelegateHidden 1");

Why are these here?  Do you think it will time out and you want to see where it does?

[youenn fablet]

> > Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278
> > +    NSLog(@"QuotaDelegateHidden 1");
> 
> Why are these here?  Do you think it will time out and you want to see where
> it does?

Yes, the current StorageQuota delegate tests time out on two debug bots (cannot repro locally though).

[youenn fablet]

Created attachment 406213 [details]
Patch for landing

[EWS]

Committed r265406: <https://trac.webkit.org/changeset/265406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406213 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66721715>

[Simon Fraser (smfr)]

Comment on attachment 406213 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=406213&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281
> +    NSLog(@"QuotaDelegateHidden 1");

Did you mean to leave in the NSLogging?

[youenn fablet]

Comment on attachment 406213 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=406213&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281
>> +    NSLog(@"QuotaDelegateHidden 1");
> 
> Did you mean to leave in the NSLogging?

Yes, I am investigating some timeout issues on specific bots in StorageQuota.mm
I plan to remove them once no longer needed.