Bug 215160

Summary: Introduce a Vector::isolatedCopy() &&
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-08-05 02:28:13 PDT
Introduce a Vector::isolatedCopy() &&. This is for instance used in RegistrationDatabase.
Attachments
Patch (4.60 KB, patch)
2020-08-05 03:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-08-05 03:21:56 PDT
Created attachment 405993 [details] Patch
Alex Christensen
Comment 2 2020-08-06 08:41:19 PDT
Comment on attachment 405993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review > Source/WTF/ChangeLog:9 > + This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges. Can we change this at the same time?
youenn fablet
Comment 3 2020-08-07 04:10:27 PDT
Comment on attachment 405993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review >> Source/WTF/ChangeLog:9 >> + This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges. > > Can we change this at the same time? RegistrationDatabase::schedulePushChanges already does WTFMove(vector).isolatedCopy()
EWS
Comment 4 2020-08-07 04:33:02 PDT
Committed r265369: <https://trac.webkit.org/changeset/265369> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405993 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-07 04:34:34 PDT
<rdar://problem/66674326>
Darin Adler
Comment 6 2020-08-07 15:55:37 PDT
Looks good!
Note You need to log in before you can comment on or make changes to this bug.