Bug 215149

Summary: AX: WebCore should provide a way to get raw role for accessibility objects
Product: WebKit Reporter: Eric Liang <ericliang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: macOS 10.15   
Attachments:
Description Flags
Patch none

Eric Liang
Reported 2020-08-04 16:51:03 PDT
AX: WebCore should provide a way to get raw role for accessibility objects This allows us to get it in the WebKit bundle
Attachments
Patch (27.47 KB, patch)
2020-08-04 17:17 PDT, Eric Liang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-08-04 16:51:16 PDT
<rdar://problem/66548775>
Eric Liang
Comment 2 2020-08-04 17:17:35 PDT
Created attachment 405963 [details] Patch
chris fleizach
Comment 3 2020-08-04 18:23:13 PDT
Comment on attachment 405963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405963&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503 > + return accessibilityRoleToString(self.axBackingObject->roleValue()); what are you going to do with this one since it's not localized?
Eric Liang
Comment 4 2020-08-04 18:28:44 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 405963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405963&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503 > > + return accessibilityRoleToString(self.axBackingObject->roleValue()); > > what are you going to do with this one since it's not localized? This is so in the WebKit iOS bundle I can check the raw roles to add container information. Yea it should not be localized.
EWS
Comment 5 2020-08-05 00:22:11 PDT
Committed r265278: <https://trac.webkit.org/changeset/265278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405963 [details].
Note You need to log in before you can comment on or make changes to this bug.