Bug 215148

Summary: Align BiquadFilterNode.getFrequencyResponse() with the specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-getfrequencyresponse
Bug Depends on: 215144    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2020-08-04 16:24:05 PDT
Align BiquadFilterNode.getFrequencyResponse() with the specification: - https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-getfrequencyresponse
Attachments
Patch (7.85 KB, patch)
2020-08-04 16:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.90 KB, patch)
2020-08-05 09:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-04 16:26:56 PDT
Created attachment 405961 [details] Patch
Eric Carlson
Comment 2 2020-08-05 09:03:26 PDT
Comment on attachment 405961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405961&action=review > Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp:89 > + return Exception { InvalidStateError, "The arrays passed in argument must have the same length" }; s/arrays passed in argument/arrays passed as arguments/
Chris Dumez
Comment 3 2020-08-05 09:10:41 PDT
Created attachment 406004 [details] Patch
EWS
Comment 4 2020-08-05 09:54:52 PDT
Committed r265291: <https://trac.webkit.org/changeset/265291> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406004 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-05 09:55:43 PDT
<rdar://problem/66580521>
Note You need to log in before you can comment on or make changes to this bug.