Bug 215135

Summary: deduplicate WPT tests
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, annevk, bfulgham, darin, dino, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225269
https://bugs.webkit.org/show_bug.cgi?id=209735
https://bugs.webkit.org/show_bug.cgi?id=179370
https://bugs.webkit.org/show_bug.cgi?id=269655
https://bugs.webkit.org/show_bug.cgi?id=266574

Description Sam Sneddon [:gsnedders] 2020-08-04 12:55:07 PDT
Driven by Myles noticing a bunch of duplication (which already led to Bug 215073), here's a bunch of directories which appear to substantially be derived from WPT tests:

(unimported) ./imported/w3c/web-platform-tests/css/CSS2 maps to ./css2.1/20110323/ and ./css2.1/tables/ (./css2.1/ also, but the mapping between files to those in WPT is, well, I don't know how to figure that out in any sane way)

(unimported) ./imported/w3c/web-platform-tests/css/css-conditional/ maps to ./css3/conditional/w3c/

(unimported) ./imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/ maps to ./svg/clip-path/

(unimported) ./imported/w3c/web-platform-tests/webvtt/ maps to ./media/track/opera/track/webvtt/

./imported/w3c/web-platform-tests/content-security-policy/ maps to ./http/tests/security/contentSecurityPolicy/1.1/

./imported/w3c/web-platform-tests/css/css-backgrounds/ maps to ./ietestcenter/css3/bordersbackgrounds/

./imported/w3c/web-platform-tests/css/css-shapes/ maps to ./css3/shapes/

./imported/w3c/web-platform-tests/css/css-writing-modes/ maps to ./imported/blink/imported/csswg-test/css-writing-modes-3/ *and* ./imported/w3c/i18n/bidi/

./imported/w3c/web-platform-tests/html/canvas/element/ and ./imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/ maps to ./canvas/philip/tests/2d.composite.operation.highlight.html *and* ./imported/w3c/canvas/

./imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/ maps to ./media/track/

./imported/w3c/web-platform-tests/svg/ maps to ./svg/

./imported/w3c/web-platform-tests/webaudio/ maps to ./webaudio/

---

CSS2 is probably relatively high-value to get imported as a whole with Bug 215087,  but poses a number of challenges: it contains 82% of all visual tests (i.e., "screenshot comparison" tests) in WPT which nobody current runs. We could import them as dumpAsText tests, which would provide most of the value without the infinite pain of PNGs. Starting to run all of them would, however, cause a substantial increase in number of tests run (we currently run ~1.1k CSS2 tests, WPT contains 9.5k).
Comment 1 Radar WebKit Bug Importer 2020-08-11 13:01:22 PDT
<rdar://problem/66856722>
Comment 2 Darin Adler 2022-10-12 16:38:33 PDT
(In reply to Sam Sneddon [:gsnedders] from comment #0)
> here's a bunch of directories which appear to substantially be
> derived from WPT tests:

Not a critical point, but I believe most of these tests that match aren’t actually derived from WPT tests, it’s more the other direction. WPT tests were derived from these, or have common ancestry.
Comment 3 Anne van Kesteren 2023-09-08 01:20:48 PDT
This is also true for the html5lib tests, which I'd like to remove once https://github.com/web-platform-tests/wpt/issues/27868 is fixed. (As otherwise it would be too hard to add new tests locally.)
Comment 4 Ahmad Saleem 2024-02-19 14:21:27 PST
svg/animations - de-duplicated (some what) -> https://github.com/WebKit/WebKit/commit/2a92632912838a769ab5ec563052e34438298c03

svg/dom - de-duplicated (again upto certain level) -> https://github.com/WebKit/WebKit/commit/a245d3c9c9b415a71a95fa1248bbf7586b51b6fb

media/track - de-duplicated (one patch landed and unskipped initial set of tests) (another to go) -> https://github.com/WebKit/WebKit/commit/1fcbc136b4143a32dca6429fa0679c24cd41e763 & https://github.com/WebKit/WebKit/commit/92e050e938089e40b97e9cf7800ec8c3f94249b4

> SVG Clip-path done by Rob -https://github.com/WebKit/WebKit/commit/649d511f93de1d6e06acbd1d00286fd18388afb0

__

Just keeping track here for future reference.
Comment 5 Sam Sneddon [:gsnedders] 2024-03-01 05:54:33 PST
(unimported) ./imported/w3c/web-platform-tests/css/CSS2/css1 maps to ./css1 (but again, no easy mapping between filenames)