Bug 215125

Summary: Remove AudioSampleDataSource::setPaused
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, ggaren, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215127    
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2020-08-04 06:36:44 PDT
It is no longer used and can prevent m_transitioningFromPaused from being true
Attachments
Patch (3.46 KB, patch)
2020-08-04 06:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-08-04 06:39:25 PDT
Created attachment 405916 [details] Patch
Geoffrey Garen
Comment 2 2020-08-04 08:55:31 PDT
Comment on attachment 405916 [details] Patch r=me Seems like m_transitioningFromPaused should be removed too?
youenn fablet
Comment 3 2020-08-04 08:58:59 PDT
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 405916 [details] > Patch > > r=me > > Seems like m_transitioningFromPaused should be removed too? m_transitioningFromPaused is used to initialize the output sample timestamp offset. I'll rename it in https://bugs.webkit.org/show_bug.cgi?id=215127.
EWS
Comment 4 2020-08-04 09:01:30 PDT
Committed r265244: <https://trac.webkit.org/changeset/265244> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405916 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-04 09:02:22 PDT
<rdar://problem/66525590>
Note You need to log in before you can comment on or make changes to this bug.