Bug 21512

Summary:

Change DOMWindow timer clamp to 4ms for V8

Product:

WebKit

Reporter:

Mike Belshe <mbelshe>

Component:

WebCore Misc.

Assignee:

Mike Belshe <mbelshe>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
DOMWindow.cpp patch	none

Description Mike Belshe 2008-10-09 19:18:38 PDT

To avoid potential CPU starvation issues; increase the timer clamp from 1ms to 4ms, and bring back the dynamic throttle which introduces the clamp only after successive small timers.

Comment 1 Mike Belshe 2008-10-09 19:22:22 PDT

Created attachment 24250 [details]
DOMWindow.cpp patch

* Raise the clamp from 1ms to 4ms.
* Re-add the dynamic clamp (timerNestingLevel).  We should figure out how to merge this code with JSDOMWindowBase.
* Fix whitespace style issues.
* Changes are confined to ifdef V8 areas.

Comment 2 Eric Seidel (no email) 2008-10-09 19:33:15 PDT

Comment on attachment 24250 [details]
DOMWindow.cpp patch

I'm wondering if this is against WebKit's DOM window since timerFired has the { on the "wrong" place.  Sam should really be the one to look at this.

Comment 3 Mike Belshe 2008-10-09 19:40:34 PDT

Invalidating this bug.

Eric points out that I was confused about how the branching is being done.

Will submit later when this is relevant.