Bug 215086

Summary: results.webkit.org: Return worker status to caller
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-08-03 09:36:56 PDT
At the moment, the worker process has no way to know if it's actually successful in processing archives. We should return that information, instead of relying solely on exceptions.
Attachments
Patch (2.69 KB, patch)
2020-08-03 09:43 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (5.70 KB, patch)
2020-08-04 15:07 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.71 KB, patch)
2020-08-05 13:32 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-08-03 09:40:34 PDT
<rdar://problem/66476525>
Jonathan Bedard
Comment 2 2020-08-03 09:43:35 PDT
Created attachment 405842 [details] Patch
Jonathan Bedard
Comment 3 2020-08-04 15:07:58 PDT
Created attachment 405950 [details] Patch
Aakash Jain
Comment 4 2020-08-05 07:03:14 PDT
Comment on attachment 405950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405950&action=review > Tools/resultsdbpy/resultsdbpy/model/upload_context.py:200 > def do_processing_work(self): when is this function expected to return false?
Jonathan Bedard
Comment 5 2020-08-05 07:15:25 PDT
Comment on attachment 405950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405950&action=review >> Tools/resultsdbpy/resultsdbpy/model/upload_context.py:200 >> def do_processing_work(self): > > when is this function expected to return false? This function should return false if no jobs are completed successfully, indicating that a given worker, for some reason, is stuck.
Aakash Jain
Comment 6 2020-08-05 13:01:22 PDT
Comment on attachment 405950 [details] Patch rs=me
Jonathan Bedard
Comment 7 2020-08-05 13:32:17 PDT
Created attachment 406032 [details] Patch for landing
EWS
Comment 8 2020-08-05 14:12:32 PDT
Committed r265305: <https://trac.webkit.org/changeset/265305> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406032 [details].
Note You need to log in before you can comment on or make changes to this bug.