Bug 215083

Summary: Add constructor to DelayNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clark_wang, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-08-03 09:00:46 PDT
Add constructor to DelayNode: - https://www.w3.org/TR/webaudio/#DelayNode
Attachments
Patch (43.38 KB, patch)
2020-08-03 11:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-03 11:05:48 PDT
Created attachment 405851 [details] Patch
Clark Wang
Comment 2 2020-08-03 11:34:43 PDT
Comment on attachment 405851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review > Source/WebCore/Modules/webaudio/DelayNode.h:36 > + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); I think DelayOptions parameter is optional, so should provide a default value.
Chris Dumez
Comment 3 2020-08-03 11:35:54 PDT
Comment on attachment 405851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review >> Source/WebCore/Modules/webaudio/DelayNode.h:36 >> + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); > > I think DelayOptions parameter is optional, so should provide a default value. It is not necessary. Bindings are smart enough to always pass us a default-initialized dictionary.
Clark Wang
Comment 4 2020-08-03 11:43:39 PDT
(In reply to Chris Dumez from comment #3) > Comment on attachment 405851 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405851&action=review > > >> Source/WebCore/Modules/webaudio/DelayNode.h:36 > >> + static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&); > > > > I think DelayOptions parameter is optional, so should provide a default value. > > It is not necessary. Bindings are smart enough to always pass us a > default-initialized dictionary. Ah interesting, I'll take this into account for my future patches as well.
EWS
Comment 5 2020-08-03 14:49:46 PDT
Committed r265221: <https://trac.webkit.org/changeset/265221> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405851 [details].
Radar WebKit Bug Importer
Comment 6 2020-08-03 16:24:50 PDT
<rdar://problem/66497071>
Note You need to log in before you can comment on or make changes to this bug.