Bug 215072

Summary: Improve the check-for-duplicated-platform-test-results script
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, darin, ews-watchlist, glenn, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215069
https://bugs.webkit.org/show_bug.cgi?id=176686
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2020-08-01 21:37:48 PDT
Improve the check-for-duplicated-platform-test-results script
Comment 1 Simon Fraser (smfr) 2020-08-01 21:43:39 PDT
Created attachment 405806 [details]
Patch
Comment 2 Darin Adler 2020-08-02 12:25:32 PDT
I haven’t studied the relationship between the two, but I would love it if the rules for search path in run-webkit-tests was the same as in this script. So if it changed, the two would continue to share the same behavior. Seems possible given all the library things we do with Python.
Comment 3 Simon Fraser (smfr) 2020-08-02 23:22:41 PDT
(In reply to Darin Adler from comment #2)
> I haven’t studied the relationship between the two, but I would love it if
> the rules for search path in run-webkit-tests was the same as in this
> script. So if it changed, the two would continue to share the same behavior.
> Seems possible given all the library things we do with Python.

I think this script gets its search path rules from webkitpy, so they should be the same.

What's odd about this script is that it creates Ports for platforms which are not the current platform, which never happens with run-webkit-tests. That probably results in some differences.
Comment 4 EWS 2020-08-02 23:41:50 PDT
Committed r265191: <https://trac.webkit.org/changeset/265191>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405806 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-03 13:33:01 PDT
<rdar://problem/66489056>