Bug 215068

Summary:

[LFC][IFC] LineBuilder:Run should not have vertical geometry

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

215087, 215752

Attachments:

Description	Flags
Patch	none
Patch	koivisto: review+
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

alan

Reported 2020-08-01 17:24:50 PDT

LineBuilder does not align runs vertically (actually no alignment at all)

Attachments
Patch (28.93 KB, patch) 2020-08-01 17:35 PDT, alan	no flags	Details Formatted Diff Diff
Patch (29.38 KB, patch) 2020-08-27 06:06 PDT, alan	koivisto: review+	Details Formatted Diff Diff
Patch (52.29 KB, patch) 2020-08-27 08:45 PDT, alan	no flags	Details Formatted Diff Diff
Patch (29.51 KB, patch) 2020-08-27 08:54 PDT, alan	no flags	Details Formatted Diff Diff
Patch (35.79 KB, patch) 2020-08-27 16:21 PDT, alan	no flags	Details Formatted Diff Diff
Patch (36.14 KB, patch) 2020-08-27 16:55 PDT, alan	no flags	Details Formatted Diff Diff
Patch (36.78 KB, patch) 2020-08-27 19:05 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2020-08-01 17:35:53 PDT

Created attachment 405801 [details] Patch

Radar WebKit Bug Importer

Comment 2 2020-08-08 17:25:15 PDT

<rdar://problem/66736366>

alan

Comment 3 2020-08-27 06:06:44 PDT

Created attachment 407394 [details] Patch

Antti Koivisto

Comment 4 2020-08-27 06:14:27 PDT

Comment on attachment 407394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407394&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:178 > - // and the trimmed width should be capped at std::min(run.trailingWhitespaceWidth(), overflowWidth) for texgt runs. Both FF and Chrome agree. > + // and the trimmed width should be capped at std::min(run.trailingWhitespaceWidth(), overflowWidth) for text runs. Both FF and Chrome agree. Great spelling fixes! > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:394 > - // Note that just becasue the trimmable width is 0 (font-size: 0px), it does not mean we don't have a trimmable trailing content. > + // Note that just because the trimmable width is 0 (font-size: 0px), it does not mean we don't have a trimmable trailing content. Here too. > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:401 > - // Do not add trimmable letter spacing after a fully trimmable whitesapce. > + // Do not add trimmable letter spacing after a fully trimmable whitespace. And here.

alan

Comment 5 2020-08-27 08:45:21 PDT

Created attachment 407402 [details] Patch

alan

Comment 6 2020-08-27 08:54:36 PDT

Created attachment 407403 [details] Patch

alan

Comment 7 2020-08-27 16:21:21 PDT

Created attachment 407432 [details] Patch

alan

Comment 8 2020-08-27 16:55:26 PDT

Created attachment 407438 [details] Patch