Bug 215041

Summary: [WinCairo] WebKitTestRunner should support pixel dump for accelerated compositing mode
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Tools / TestsAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, don.olmstead, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=247479
Attachments:
Description Flags
WIP patch
none
Playwright script
none
WIP patch
none
WIP patch
none
WIP patch
none
Patch none

Fujii Hironori
Reported 2020-07-31 16:10:00 PDT
[WinCairo] DumpRenderTree and WebKitTestRunner doesn's support pixel dump for accelerated compositing mode AppleWin supports it. CACFLayerTreeHost::paint seems do the task. Bug 46849 – [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
Attachments
WIP patch (7.16 KB, patch)
2020-07-31 16:13 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Playwright script (564 bytes, text/javascript)
2021-10-20 23:52 PDT, Fujii Hironori 		no flags
Details
WIP patch (9.68 KB, patch)
2022-01-16 22:57 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (19.60 KB, patch)
2022-01-17 23:45 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
WIP patch (33.81 KB, patch)
2022-01-25 14:12 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (40.05 KB, patch)
2022-01-25 22:41 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-31 16:13:11 PDT
Created attachment 405755 [details] WIP patch BitBlt can capture the window content. But, the problem is the windows shoudd be visible and needs diabling WindowStaion.
Fujii Hironori
Comment 2 2021-10-20 23:52:56 PDT
Created attachment 441991 [details] Playwright script I checked Playwright screen capture feature on Windows. Chrome and Firefox can capture the browser window both in headless and non-headless modes. WebKit (WinCairo based) can capture only in non-headless modes. I should check how Chrome and Firefox capture in the headless mode. winget openjs.nodejs npm install playwright node video.mjs
Fujii Hironori
Comment 3 2022-01-16 22:57:25 PST
Created attachment 449309 [details] WIP patch
Fujii Hironori
Comment 4 2022-01-17 23:45:33 PST
Created attachment 449364 [details] WIP patch
Fujii Hironori
Comment 5 2022-01-25 14:12:33 PST
Created attachment 449966 [details] WIP patch
Fujii Hironori
Comment 6 2022-01-25 22:41:06 PST
Created attachment 449997 [details] Patch
Don Olmstead
Comment 7 2022-01-27 15:09:03 PST
Comment on attachment 449997 [details] Patch Is this all that's needed to get pixel tests working? TestController:::takeViewPortSnapshot is unimplemented on Windows.
Fujii Hironori
Comment 8 2022-01-27 16:54:16 PST
(In reply to Don Olmstead from comment #7) > Comment on attachment 449997 [details] > Patch > > Is this all that's needed to get pixel tests working? > TestController:::takeViewPortSnapshot is unimplemented on Windows. Yes, this patch makes AC mode pixel tests pass. However, DRT doesn't support it. takeViewPortSnapshot is used only by fast/mediastream tests (Bug 231059).
EWS
Comment 9 2022-01-28 21:23:28 PST
Committed r288784 (246561@main): <https://commits.webkit.org/246561@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449997 [details].
Radar WebKit Bug Importer
Comment 10 2022-01-28 21:24:19 PST
<rdar://problem/88217028>
Note You need to log in before you can comment on or make changes to this bug.